Overview

Request 1097831 superseded

- Change to version 2022.12.22
* Specfile and service cleanup
* Required by PrusaSlicer 2.6: requires the fltk fork from the
tag fltk_2022-12-22 or later
* Add soversion and adhere to shlib policy
nanosvg-add-soversion.patch
gh#memononen/nanosvg#242
- Initial version 0.0.1~git.abcd277 copied from Mike Chikov
at home:mrbadguy:3dPrinting/nanosvg
- Includes fix-cname-dest.patch

Loading...


Atri Bhattacharya's avatar

Thanks, and sorry for the delay in reviewing.

Looks good to me overall, but:

  • PATCH-FIX-SUSE fix-cname-dest.patch... should be PATCH-FIX-UPSTREAM as it seems this patch could be (is already?) submitted upstream and nothing specific to (open)SUSE. Also a one-line summary of what the patch does would be useful here and the upstream bug reference, if there is one.
  • As the main summary says this is a single header file, I wonder what the shared libs are about, and the descriptions for both of the shared libs are too brief to help. A tad more explanation of the libs do would be much appreciated.

Also, please run spec-cleaner over the specfile to sort out minor cosmetic issues (tag alignment, for example).

Thanks again.

Request History
Benjamin Greiner's avatar

bnavigator created request

- Change to version 2022.12.22
* Specfile and service cleanup
* Required by PrusaSlicer 2.6: requires the fltk fork from the
tag fltk_2022-12-22 or later
* Add soversion and adhere to shlib policy
nanosvg-add-soversion.patch
gh#memononen/nanosvg#242
- Initial version 0.0.1~git.abcd277 copied from Mike Chikov
at home:mrbadguy:3dPrinting/nanosvg
- Includes fix-cname-dest.patch


Benjamin Greiner's avatar

bnavigator added gnome-review-bot as a reviewer

please check as factory would check


GNOME Review Bot's avatar

gnome-review-bot accepted review

Check script succeeded


GNOME Review Bot's avatar

gnome-review-bot approved review

Check script succeeded


Benjamin Greiner's avatar

bnavigator superseded request

superseded by 1099781

openSUSE Build Service is sponsored by