Overview

Request 1099781 accepted

addressing review

Loading...


Atri Bhattacharya's avatar

Thanks, and sorry for the delay in reviewing.

Looks good to me overall, but:

  • PATCH-FIX-SUSE fix-cname-dest.patch... should be PATCH-FIX-UPSTREAM as it seems this patch could be (is already?) submitted upstream and nothing specific to (open)SUSE. Also a one-line summary of what the patch does would be useful here and the upstream bug reference, if there is one.
  • As the main summary says this is a single header file, I wonder what the shared libs are about, and the descriptions for both of the shared libs are too brief to help. A tad more explanation of the libs do would be much appreciated.

Also, please run spec-cleaner over the specfile to sort out minor cosmetic issues (tag alignment, for example).

Thanks again.

Request History
Benjamin Greiner's avatar

bnavigator created request

addressing review


Atri Bhattacharya's avatar

badshah400 accepted request

Many thanks

openSUSE Build Service is sponsored by